Depends on what one is looking for. I'm considering upgrading to an M5 model because while the M6 redesign might come with some nicer specs, it's also going to be coming with some teething pains by virtue of having a new design. The M5 generation is probably going to be a speed bump with a chassis and screen that's a known quantity and has had the kinks smoothed out.
I skipped the touchbar/buttery era, but before that the GPU/ballgate disaster plagued the MacBookPro lineup — pushed me away from Apple hardware for over decade!
My vision has since gotten bad enough that I can't really use laptops/phones well, anymore — but recently got a 15" MacBookAir, M3 pre-Tahoe (for bedtime youtubies).
The hardware is exceptional, battery life even more so... and I'll never update the operating system.